Editor: Memoize 'getNestedEditedPostProperty' selector helper #54160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +14 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cd8b821. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6076997090
|
Member
Author
|
Thanks for the review, @jsnajdr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Memoize the
getNestedEditedPostPropertyselector helper to avoid returning different values when called with the same state and parameters.Why?
While working on #54159, I noticed that
getEditedPostAttribute( 'meta' )would return a different value on each call after making edits to the post meta.When the meta property has been edited, the
getEditedPostAttributewill callgetNestedEditedPostPropertyinternally, where merged values weren't memoized.Testing Instructions
PR includes the unit test.
Prior to #54159.
npm run dev.useSelectwarning will be logged in the console.Screenshots or screencast